Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slice! method to ActiveModel::Errors #34489

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
5 participants
@6temes
Copy link
Contributor

commented Nov 20, 2018

Summary

ActiveModel::Errors implements several methods from Hash but not all of them.

The method slice! is provided to Hash via ActiveSuport and it could be really convenient to have it as well in ActiveModel::Errors for situations when the developer needs to delete several errors from a model.

@rails-bot

This comment has been minimized.

Copy link

commented Nov 20, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

# person.errors.slice!(:age, :gender) # => { :age=>["cannot be nil"], :gender=>["cannot be nil"]}
# person.errors.keys(:name, :age) # => [:name]
def slice!(*keys)
keys.inject({}) do |acc, key|

This comment has been minimized.

Copy link
@gmcgibbon

gmcgibbon Nov 20, 2018

Member

The messages and details are both hashes. I think it makes more sense for us to just use slice! on those like we do with merge!, right?

person.errors.add(:gender, "cannot be nil")
person.errors.add(:city, "cannot be nil")

removed_errors = person.errors.slice!(:age, :gender)

This comment has been minimized.

Copy link
@rafaelfranca

rafaelfranca Nov 20, 2018

Member

We need a test with string keys, since all other methods support both strings and symbols.

This comment has been minimized.

Copy link
@6temes

6temes Nov 20, 2018

Author Contributor

Sure!

Should I mix strings and symbols in this test or is it better to create another test just for that?

This comment has been minimized.

Copy link
@rafaelfranca

rafaelfranca Nov 20, 2018

Member

You can mix them if you want.

This comment has been minimized.

Copy link
@6temes

6temes Nov 20, 2018

Author Contributor

Oh, I understand! This method should allow strings or symbols to be passed indifferently. I have a failing test now.

@rafaelfranca
Copy link
Member

left a comment

This looks good. Can you add a CHANGELOG entry and also squash all commits in one?

@6temes

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2018

Done!

Tests are passing now.

@rafaelfranca rafaelfranca merged commit 3269506 into rails:master Nov 21, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rafaelfranca

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

Thank you so much! Nice work

@6temes 6temes deleted the 6temes:add_slice_method_to_errors branch Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.