Commits on May 22, 2019

1. Keep part when scope option has value …

   When a route was defined within an optional scope, if that route didn't
   take parameters the scope was lost when using path helpers. This patch
   ensures scope is kept both when the route takes parameters or when it
   doesn't.
   
   Fixes #33219

   

   albertoalmagro committed May 22, 2019
   Copy the full SHA

   fb9117e View commit details

   Browse the repository at this point in the history

2. Use keyword arguments for ActionDispatch::Journey:Route constructor …

   This commit changes from constructor's argument list to keyword
   arguments in order to remove the dependency of remember parameters'
   positions.
   
   The constructor already provided a default value for `internal`, this
   commits takes the chance to also add default values for `precedence` and
   `scope_options`.

   

   albertoalmagro committed May 22, 2019
   Copy the full SHA

   29506d0 View commit details

   Browse the repository at this point in the history

3. Use keyword arguments for ActionDispatch::Routing::Mapper::Mapping co… …

   …nstructor
   
   This commit changes from constructor's argument list to keyword
   arguments in order to remove the dependency of remember parameters'
   positions.
   
   It also unifies all parameters extracted from the `scope` into
   `scope_params`, which also takes care of providing the default values
   for them.

   

   albertoalmagro committed May 22, 2019
   Copy the full SHA

   963b3ed View commit details

   Browse the repository at this point in the history

4. Remove Route#build as it wasn't used …

   After @kamipo CR feedback we realized `Route#build` wasn't used. As it
   is also private API being able to create Routes both with `#new` and
   `#build` was redundant.

   

   albertoalmagro committed May 22, 2019
   Copy the full SHA

   20104ba View commit details

   Browse the repository at this point in the history