Add i18n capabilities to ActiveSupport::Inflector#titleize #34844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original version of titleize used to capitalize all words. Unfortunately, this isn't a universal rule and should be configurable on a per language basis. This PR moves the titleize logic to I18n in such a way that each language can define how sentences should be titleized.
gmcgibbon
reviewed
Jan 2, 2019
There was a problem hiding this comment.
I like this idea, but I think this PR and the previously merged one don't take into account a default locale that isn't :en.
I18n.default_locale = :ja
1.ordinalize
# => "translation missing: ja.number.nth.ordinalized"They both seem like breaking changes to me. Can we instead make the procs a default value for any locale, or perhaps that's not possible? Maybe something to patch in a followup PR.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what #32168 did to
ordinalandordinalized, this PR adds I18n capabilities totitleize.Summary
titleizecurrently capitalizes all the words of a string, which unfortunately doesn't work in all languages. Taking "raiders of the lost ark" as an example, what would become "Raiders Of The Lost Ark" in English should instead become "Raiders of the lost ark" in French. Other languages might very well treat this differently too. This PR moves the logic to an I18n rule, where each language will be able to define their own rule.I was afraid
titleizecould be used for some internal mechanics, but the method definition clearly state otherwise. Given that information, this should be a safe change.Other Information
This is a noop. The English rule acts exactly the same as it used too, and no other languages are provided by default.