Fix deeply nested namespace command printing #35033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
force-pushed
the
multilevel_command_root_namespace
branch
from
6304b25
to
0a955e3
Compare
gmcgibbon
force-pushed
the
multilevel_command_root_namespace
branch
from
0a955e3
to
a670654
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deeply nested commands currently don't get printed properly. See #34832 (comment). This should fix that by allowing
Rails::Command::Base#command_root_namespaceto include nested namespace segments, and not just the first one.I tried making it so
command_root_namespaceexcluded thecommand_nameas well, but that didn't play nicely with method-based command definition (eg.SecretsCommand). The regex I use innamespaced_commandsis probably not the best approach, any feedback here would be appreciated.