[UPDATED] Implement a way to add browser capabilities #35081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There is currently no way to define specific browser capabilities since our SystemTest driver override the `option` key [Ref](https://github.com/rails/rails/blob/a07d0680787ced3c04b362fa7a238c918211ac70/actionpack/lib/action_dispatch/system_testing/driver.rb#L35) This option key is used internally by selenium to add custom capabilities on the browser. Depending on the Browser, some option are allowed to be passed inside a hash, the driver takes care of setting whatever you passed on the driver option. An example [here](https://github.com/rails/rails/blob/a07d0680787ced3c04b362fa7a238c918211ac70/actionpack/lib/action_dispatch/system_testing/driver.rb#L35) where you are allowed to pass args such as `--no-sandbox` etc However this behavior was only meant for backward compatibility and as you can see it's deprecated. The non-deprecated behavior is to create a `<Driver>::Option` object containing all the capabilities we want. This is what we [currently do](https://github.com/rails/rails/blob/a07d0680787ced3c04b362fa7a238c918211ac70/actionpack/lib/action_dispatch/system_testing/browser.rb#L34-L36) when chrome or firefox are in headless mode. This PR allows to pass a block when calling `driven_by`, the block will be pased a `<Driver>::Option` instance. You can modify this object the way you want by adding any capabilities. The option object will be then passed to selenium. ```ruby driven_by :selenium, using: :chrome do |driver_option| driver_option.add_argument('--no-sandbox') driver_option.add_emulation(device: 'iphone 4') end ```
eileencodes
force-pushed
the
ec-driver-option-updated
branch
from
af264dc
to
3fb4543
Compare
This is a minor update to the named methods for the following: - s/desired_capabilities/capabilities - s/driver_options/capabilities Since they are all the same thing we should keep the name the same throughout the feature. Updated docs to match / be a little bit clearer Also updated the Gemfile for selenium-webdriver.
eileencodes
force-pushed
the
ec-driver-option-updated
branch
from
3fb4543
to
1a4f613
Compare
Edouard-chin
approved these changes
Jan 29, 2019
|
No worries @Edouard-chin we've all been there! |
This was referenced Jan 29, 2019
kamipo
reviewed
Jan 30, 2019
| @@ -432,9 +433,9 @@ GEM | |||
| tilt (>= 1.1, < 3) | |||
| sdoc (1.0.0) | |||
| rdoc (>= 5.0) | |||
| selenium-webdriver (3.141.0) | |||
| selenium-webdriver (3.5.2) | |||
There was a problem hiding this comment.
Why version locked "~> 3.5.1" (version down 3.141.0 to 3.5.2)?
There was a problem hiding this comment.
That was by accident. Next time you fix it in master can you leave a note here so I don't spend time starting to fix it? 😄 Thanks!
Fixed in 1cfa913
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Aug 3, 2019
[UPDATED] Implement a way to add browser capabilities rails/rails#35081
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Aug 3, 2019
[UPDATED] Implement a way to add browser capabilities rails/rails#35081
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Aug 11, 2019
[UPDATED] Implement a way to add browser capabilities rails/rails#35081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Edouard-chin I wanted to get this in for Rails 6 (sorry for the delay before that) but there were some changes I would like to see and you seemed to be less around lately.
Hope you don't mind I took your PR and made a couple of changes:
Thank you for all your work on this! I super appreciate you taking the time to improve system tests.
Update of #32442