Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pluck and select with from if from has original table name #35360

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Fix pluck and select with from if from has original table name #35360

merged 2 commits into from
Feb 21, 2019

Commits on Feb 21, 2019

  1. Fix pluck and select with from if from has original table name 

    This is caused by 0ee96d1.

Since rails#18744, `select` columns doesn't be qualified by table name if
using `from`. 0ee96d1 follows that for `pluck` as well.

But people depends that `pluck` columns are qualified even if using
`from`.

So I've fixed that to be qualified if `from` has the original table name
to keep the behavior as much as before.

Fixes rails#35359.
    @kamipo
    kamipo committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    6e599ee View commit details
    Browse the repository at this point in the history

  2. Just skip `test_select_with_subquery_in_from_uses_original_table_name… 

    …` on Travis

I'm not sure why the test is failed on Travis, it passed on locally.

I suspect that failure is a bug on SQLite3, so just skip the test for
now, since it was not covered by before.

https://travis-ci.org/rails/rails/jobs/496726410#L1198-L1208
    @kamipo
    kamipo committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    04a4789 View commit details
    Browse the repository at this point in the history