Add note about has_many associations callbacks #35530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rodrigora
changed the title
vipulnsward
reviewed
Mar 9, 2019
vipulnsward
reviewed
Mar 9, 2019
vipulnsward
reviewed
Mar 9, 2019
Add a note explaining when the has_many associations callbacks will be called or not.
|
Thanks for the review @vipulnsward . It is updated |
|
Thanks! |
abhaynikam
reviewed
Mar 12, 2019
| @@ -2350,6 +2350,17 @@ end | |||
|
|
|||
| If a `before_add` callback throws an exception, the object does not get added to the collection. Similarly, if a `before_remove` callback throws an exception, the object does not get removed from the collection. | |||
|
|
|||
| NOTE: These callbacks are called only when the associated objects are added or removed through the association collection: | |||
There was a problem hiding this comment.
@vipulnsward : remove through the associated sounds little incorrect to me. Maybe we could say removed from the association collection.
Changes:
through->from- Sentence should end with period here
Does that sound correct to you?
There was a problem hiding this comment.
It's correct as is. The idea is to communicate that adds/removals must go through the has_many accessor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a note explaining when the has_many associations callbacks will be called or not.
Other Information
The documented behaviour seems to cause some confusion for some people (including myself).
https://www.google.com/search?q=has_many+callbacks+not+working&rlz=1C5CHFA_enIE796IE796&oq=has_many+callbacks+not+working&aqs=chrome..69i57.8047j0j7&sourceid=chrome&ie=UTF-8