[Rails::MailersController] Do not leak I18n global setting changes #35997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjoyal
commented
Apr 16, 2019
| @@ -5,8 +5,9 @@ | |||
| class Rails::MailersController < Rails::ApplicationController # :nodoc: | |||
| prepend_view_path ActionDispatch::DebugView::RESCUES_TEMPLATE_PATH | |||
|
|
|||
| around_action :set_locale, only: :preview | |||
| before_action :find_preview, only: :preview | |||
| before_action :require_local!, unless: :show_previews? | |||
There was a problem hiding this comment.
Since this is gated by the route to simply not be present, I'm not certain why it is required. didn't alter it as part of the PR it could be done on the side if we desire.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally added here: #31596
Using the action mailer specifying a locale to the preview would leak a global I18n setting change (
I18n.locale).Since it is only exposed in development, this is not that big of a deal, only corrupt instances running in development.
rails/actionmailer/lib/action_mailer/railtie.rb
Line 29 in ed9acb4
rails/actionmailer/lib/action_mailer/railtie.rb
Lines 85 to 90 in b49e38b
Using
I18n.with_locale(locale) {...}will make certain the previous value is restored.