Autoload SyntaxErrorInTemplate #36521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsWill
force-pushed
the
autoloading_in_exceptions
branch
from
48b5ae0
to
33d52c1
Compare
itsWill
force-pushed
the
autoloading_in_exceptions
branch
2 times, most recently
from
4520d14
to
1a8abad
Compare
When a SyntaxError is detected in a template we raise this exception. On a first request to the server the exception we get a NameError since the exception is not required from `active_view/template/error.rb` yet. However later on it gets required and a second request will succeed. On the first request we see the rails "Something Wen Wrong" page and not the expected syntax error in template error page with the webconsole and stacktrace. By autoloading the constant we fix this issue. Co-authored-by: Gannon McGibbon <gannon.mcgibbon@gmail.com>
itsWill
force-pushed
the
autoloading_in_exceptions
branch
from
1a8abad
to
99e52ae
Compare
eugeneius
pushed a commit
to eugeneius/rails
that referenced
this pull request
Dec 21, 2019
Autoload SyntaxErrorInTemplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Came out of looking into this: #36341
When a SyntaxError is detected in a template we raise this exception:
SyntaxErrorInTemplate. Ona first request to the server the exception we get a NameError since the
exception is not required from
active_view/template/error.rbyet.However later on it gets required and a second request will succeed.
On the first request we see the rails "Something Wen Wrong" page and not
the expected syntax error in template error page with the webconsole and
stacktrace. By autoloading the constant we fix this issue.
Before the patch the first request looks like:
And the log information is silenced by the
DebugExceptionsmiddleware.After the patch this looks like:
cc: @gmcgibbon