Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty array instead of nil for source_extract #36532

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Empty array instead of nil for source_extract #36532

merged 1 commit into from
Jul 15, 2019

Commits on Jul 14, 2019

  1. Empty array instead of nil for source_extract 

    The source_extract method will return nil when it can't find the file name in
the backtrace, methods that consume this method expect an array and the nil ends
up causing type errors down the road like it happened here: rails#36341. This
patch refactors the source_extract method so that it returns an empty
array instead of nil when it can't find the source code.

Co-authored-by: Kasper Timm Hansen <kaspth@gmail.com>
    @kaspth
    Guilherme Mansur and kaspth committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    526a5eb View commit details
    Browse the repository at this point in the history