Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code in duplicable.rb #36658

Merged
merged 2 commits into from Jul 14, 2019
Merged

Conversation

casperisfine
Copy link
Contributor

@casperisfine casperisfine commented Jul 11, 2019

Edit: #28544

AFAIK all these feature tests are for pre 2.5.0 MRI, now that Rails requires 2.5.0+, it's no longer useful to test it.

While I was at it I added one exception for UnboundMethod that was missing.

Another class that could use it is Thread:

>> Thread.new{}.dup
TypeError (allocator undefined for Thread)

However it would mean requiring the thread module, which seems wrong.

cc @rafaelfranca @Edouard-chin

Copy link
Member

@Edouard-chin Edouard-chin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kamipo
Copy link
Member

kamipo commented Jul 12, 2019

Can you add a test for UnboundMethod here?

@casperisfine
Copy link
Contributor Author

@kamipo done!

@kamipo kamipo merged commit 4ded9b8 into rails:master Jul 14, 2019
kamipo added a commit that referenced this pull request Jul 15, 2019
Remove dead code in duplicable.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants