Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code in duplicable.rb #36658

Merged
merged 2 commits into from Jul 14, 2019
Merged

Remove dead code in duplicable.rb #36658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59f4505
Remove dead code in duplicable.rb
byroot Jul 11, 2019
7147631
Implement UnboundMethod#duplicable?
byroot Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
124 changes: 7 additions & 117 deletions activesupport/lib/active_support/core_ext/object/duplicable.rb
View file
Open in desktop
Expand Up @@ -28,96 +28,6 @@ def duplicable?
end
end

class NilClass
begin
nil.dup
rescue TypeError

# +nil+ is not duplicable:
#
# nil.duplicable? # => false
# nil.dup # => TypeError: can't dup NilClass
def duplicable?
false
end
end
end

class FalseClass
begin
false.dup
rescue TypeError

# +false+ is not duplicable:
#
# false.duplicable? # => false
# false.dup # => TypeError: can't dup FalseClass
def duplicable?
false
end
end
end

class TrueClass
begin
true.dup
rescue TypeError

# +true+ is not duplicable:
#
# true.duplicable? # => false
# true.dup # => TypeError: can't dup TrueClass
def duplicable?
false
end
end
end

class Symbol
begin
:symbol.dup

# Some symbols couldn't be duped in Ruby 2.4.0 only, due to a bug.
# This feature check catches any regression.
"symbol_from_string".to_sym.dup
rescue TypeError

# Symbols are not duplicable:
#
# :my_symbol.duplicable? # => false
# :my_symbol.dup # => TypeError: can't dup Symbol
def duplicable?
false
end
end
end

class Numeric
begin
1.dup
rescue TypeError

# Numbers are not duplicable:
#
# 3.duplicable? # => false
# 3.dup # => TypeError: can't dup Integer
def duplicable?
false
end
end
end

require "bigdecimal"
class BigDecimal
# BigDecimals are duplicable:
#
# BigDecimal("1.2").duplicable? # => true
# BigDecimal("1.2").dup # => #<BigDecimal:...,'0.12E1',18(18)>
def duplicable?
true
end
end

class Method
# Methods are not duplicable:
#
Expand All @@ -128,32 +38,12 @@ def duplicable?
end
end

class Complex
begin
Complex(1).dup
rescue TypeError

# Complexes are not duplicable:
#
# Complex(1).duplicable? # => false
# Complex(1).dup # => TypeError: can't copy Complex
def duplicable?
false
end
end
end

class Rational
begin
Rational(1).dup
rescue TypeError

# Rationals are not duplicable:
#
# Rational(1).duplicable? # => false
# Rational(1).dup # => TypeError: can't copy Rational
def duplicable?
false
end
class UnboundMethod
# Unbound methods are not duplicable:
#
# method(:puts).unbind.duplicable? # => false
# method(:puts).unbind.dup # => TypeError: allocator undefined for UnboundMethod
def duplicable?
false
end
end
2 changes: 1 addition & 1 deletion activesupport/test/core_ext/object/duplicable_test.rb
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@
require "active_support/core_ext/numeric/time"

class DuplicableTest < ActiveSupport::TestCase
RAISE_DUP = [method(:puts)]
RAISE_DUP = [method(:puts), method(:puts).unbind]
ALLOW_DUP = ["1", "symbol_from_string".to_sym, Object.new, /foo/, [], {}, Time.now, Class.new, Module.new, BigDecimal("4.56"), nil, false, true, 1, 2.3, Complex(1), Rational(1)]

def test_duplicable
Expand Down