Pass optional record in blob finder methods #36727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow record to be optionally passed to blob finders to make sharding easier.
To generically support sharded Active Storage models, we need to specify a model to shard attachments by. The polymorphic
record
can then be used by a developer in an overridden method:This change can be misconstrued as a mistake as the framework doesn't use the
record
parameter by default, so I've added some tests to make sure it doesn't get removed by mistake.cc @georgeclaghorn @rafaelfranca