Refactored remove_column #3707

Merged
merged 1 commit into from May 2, 2012

4 participants

@ebeigarts

ActiveRecord::Table#remove should use *column_names instead of column_names.

So, I have removed unnecessary flatten for column_names that also caused issues here.

@jonleighton
Ruby on Rails member

Unsure about this. I agree with the principle but there might be apps in the wild that are passing an array to remove_column. cc @tenderlove

@ebeigarts

At least it isn't documented anywhere that we can pass nested Arrays in column_names here.

@drogus
Ruby on Rails member

I would add deprecation warning and merge it after next release

@carlosantoniodasilva
Ruby on Rails member

This should be ok for master now?

@carlosantoniodasilva
Ruby on Rails member

@ebeigarts hey, could you bring this up-to-date with master, so we can review it and continue the discussion? Thanks.

@jonleighton can we go ahead to merge this in master?

@jonleighton
Ruby on Rails member

We can merge this if a deprecation is added.

@drogus
Ruby on Rails member

I've rebased that commit and added deprecation warning here: drogus@d7e60b6, @jonleighton does it look good, should I push those?

@jonleighton
Ruby on Rails member

@drogus seems fine

@drogus drogus merged commit ae8f497 into rails:master May 2, 2012
@drogus
Ruby on Rails member

I've deprecated this behavior here: 02ca915

@yahonda yahonda referenced this pull request in rsim/oracle-enhanced Aug 22, 2012
Merged

Support Refactored remove_column with Oracle #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment