ActiveRecord::Table#remove should use *column_names instead of column_names.
So, I have removed unnecessary flatten for column_names that also caused issues here.
Unsure about this. I agree with the principle but there might be apps in the wild that are passing an array to remove_column. cc @tenderlove
At least it isn't documented anywhere that we can pass nested Arrays in column_names here.
I would add deprecation warning and merge it after next release
This should be ok for master now?
@ebeigarts hey, could you bring this up-to-date with master, so we can review it and continue the discussion? Thanks.
@jonleighton can we go ahead to merge this in master?
We can merge this if a deprecation is added.
I've rebased that commit and added deprecation warning here: drogus/rails@d7e60b6, @jonleighton does it look good, should I push those?
@drogus seems fine
I've deprecated this behavior here: 02ca915