Deprecate leaking scope in callback block for association relation #37360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up of rails#35280, I missed that `AssociationRelation` is using `scoping` and not use `super`.
kamipo
added a commit
that referenced
this pull request
Oct 4, 2019
Deprecate leaking scope in callback block for association relation
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Oct 21, 2019
Related rails#35280, rails#37360, rails#37511. Using `klass.all` in `scoping` would potentially cause the warning. https://buildkite.com/rails/rails/builds/64444#203174d8-b527-4c43-9bd4-44e272f43555/996-1003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #35280, I missed that
AssociationRelationis usingscopingand not usesuper.