Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci skip] Fix lower case comments without punctuation #37562

Merged
merged 1 commit into from
Oct 28, 2019
Merged

[ci skip] Fix lower case comments without punctuation #37562

merged 1 commit into from
Oct 28, 2019

Conversation

BakiVernes
Copy link
Contributor

Summary

Documentation fix for number_helper. Comments started with a lowercase letter and had no punctuation at the end.

dixpac
dixpac approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@dixpac dixpac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kaspth kaspth merged commit b53b188 into rails:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixpac dixpac dixpac approved these changes

Assignees
No one assigned
Labels
activesupport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BakiVernes @dixpac @kaspth