Avoid using require_dependency is Zeitwerk is enabled #37599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I'm trying to disable
config.add_autoload_paths_to_load_path
in our app, which causerequire_dependency
to straight up fail when called with an autoloaded path.These were added in 1e55ee5 to workaround the classic autoloader limitations, but that's no longer a problem with Zeitwerk.
I'm not super happy with adding this kind of global config check in there, but I can't think of a better way.
@fxn, cc @eugeneius
cc @rafaelfranca @Edouard-chin @etiennebarrie