Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update caching_with_rails.md #38237

Closed
wants to merge 1 commit into from
Closed

Update caching_with_rails.md #38237

wants to merge 1 commit into from

Conversation

enowmbi
Copy link

@enowmbi enowmbi commented Jan 15, 2020

[ci skip] Added line describing how to toggle caching using rails dev:cache in development mode

[ci skip] Added line describing how to toggle caching using rails dev:cache in development mode
@enowmbi
Copy link
Author

enowmbi commented Jan 15, 2020

First time contributing to rails documentation. why are some checks not successful ? Does it mean the commit was not merged ?

@p8
Copy link
Member

p8 commented Jan 15, 2020

@enowmbi I think you have to put [ci skip] in the first line of the pull request to skip the buildkite check. This is might be beter explained in the Contributing Guidelines ;).

@@ -48,6 +48,8 @@ only have an effect on the caching provided by the Action Controller component.
For instance, it will not impact low-level caching, that we address
[below](#low-level-caching).

In Rails 5 and above, instead of editing the config/environment/development.rb file, you can toggle caching by running rails dev:cache command; running this command enables caching if not enabled, and disables caching if it is enabled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the bottom of the page there already is an explanation on how to use rails dev:cache. Maybe move that up instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your response.

@rails-bot
Copy link

rails-bot bot commented Apr 22, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label Apr 22, 2020
@rails-bot rails-bot bot closed this Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants