Deprecate and replace #default_hash and #[]
#38256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Database configurations are now objects almost everywhere, so we don't need to fake access to a hash with `#default_hash` or it's alias `#[]`. Applications should `configs_for` and pass `env_name` and `spec_name` to get the database config object. If you're looking for the default for the test environment you can pass `configs_for(env_name: "test", spec_name: "primary")`. Change test to developement to get the dev config, etc. `#default_hash` and `#[]` will be removed in 6.2. Co-authored-by: John Crepezzi <john.crepezzi@gmail.com>
carlosantoniodasilva
added a commit
to heartcombo/devise
that referenced
this pull request
Feb 3, 2021
Fix deprecation warning on Rails 6.1 Related changes in Rails: rails/rails#38256 rails/rails#38536
koic
added a commit
to koic/test-queue
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database configurations are now objects almost everywhere, so we don't
need to fake access to a hash with
#default_hashor its alias#[].Applications should
configs_forand passenv_nameandspec_nametoget the database config object. If you're looking for the default for
the test environment you can pass
configs_for(env_name: "test", spec_name: "primary"). Change test to development to get the dev config, etc.#default_hashand#[]will be removed in 6.2.Co-authored-by: John Crepezzi john.crepezzi@gmail.com