Fix wrong spec asserting headers maintain original definition #38422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in rails#20559 but was wrongly asserting %w[close] to match close as the header value
|
Thanks @vipulnsward! Wanna take a look at the other one mentioned in #38420? |
|
Ah, you're already looking at it 🙌 |
|
Also, just FYI, you definitely shouldn't be setting connection headers unless you are actually know the server will handle it correctly. e.g. falcon will delete this header from the app response, and issue a warning. |
|
Yep, sounds sensible 🙏 |
kamipo
pushed a commit
that referenced
this pull request
May 18, 2020
Fix wrong spec asserting headers maintain original definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #20559 but was wrongly asserting %w[close] to match "close" as the header value
Changes from rack/rack@d2e608e returns headers as is which makes this break.