Update some references to finder options [ci skip] #38559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing conditions to `find` was deprecated in Rails 4.0.
kaspth
approved these changes
Feb 24, 2020
| # Raised when number of bind variables in statement given to +:condition+ key | ||
| # (for example, when using {ActiveRecord::Base.find}[rdoc-ref:FinderMethods#find] method) | ||
| # does not match number of expected values supplied. | ||
| # Raised when the number of placeholders in an SQL fragment passed to |
There was a problem hiding this comment.
It depends whether you pronounce SQL as an initialism or as "sequel", which makes it ambiguous and somewhat controversial. 😄
The precedent in the rest of the codebase is to use "an": https://github.com/rails/rails/search?q=%22an+SQL%22
gmcgibbon
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing conditions to
findwas deprecated in Rails 4.0.