Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I18n.translate
returnsnil
when given anil
key, unless adefault
is also specified. If adefault
is specified, thenil
key is treated as a missing key.In Rails 6.0, the
translate
helper always returnednil
when given anil
key. After #40773, thetranslate
helper always raised anI18n::ArgumentError
when given anil
key. This commit fixes thetranslate
helper to mirror theI18n.translate
behavior when given anil
key, with and without adefault
.Fixes #40773 (comment).
Since this changes the behavior of the
translate
helper when both anil
key and adefault
are specified, I've added a CHANGELOG entry. If we do not want to change this for 6.1.1, I can create a separate PR against6-1-stable
that restores the Rails 6.0 behavior fornil
keys.