Link preloading should keep integrity hashes in the header #40841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a stylesheet or javascript link tag (or preload link tag) is output in the view, it also gets sent as a Link header for preloading. This Link header is missing the integrity attribute even when one is set on the tag, which prevents the browser from using the preloaded resource. Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
etiennebarrie
force-pushed
the
link-preload-integrity
branch
from
fd4c4e9
to
4aa9126
Compare
rafaelfranca
added a commit
that referenced
this pull request
Dec 17, 2020
Link preloading should keep integrity hashes in the header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a stylesheet or javascript link tag (or preload link tag) is output in the view, it also gets sent as a Link header for preloading. This Link header is missing the integrity attribute even when one is set on the tag, which prevents the browser from using the preloaded resource.
On Chrome, having an integrity hash on the stylesheet <link> tag, causes a console warning because the hash is missing from the Link header:
It also causes a double load of the resource, because the preloaded one without the integrity is dropped,