Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kyiv timezone mapping value #40959

Closed
wants to merge 1 commit into from
Closed

Conversation

metisigor
Copy link

@rafaelfranca
Copy link
Member

Thank you for the pull request but the tzdata use Europe/Kiev as the name of the zone and we can't change in the framework without the tzdata changing it.

See https://github.com/tzinfo/tzinfo-data/blob/master/lib/tzinfo/data/definitions/Europe/Kiev.rb and the content of https://www.iana.org/time-zones

# From Paul Eggert (2018-10-03):
# As is usual in tzdb, Ukrainian zones use the most common English spellings.
# For example, tzdb uses Europe/Kiev, as "Kiev" is the most common spelling in
# English for Ukraine's capital, even though it is certainly wrong as a
# transliteration of the Ukrainian "Київ".  This is similar to tzdb's use of
# Europe/Prague, which is certainly wrong as a transliteration of the Czech
# "Praha".  ("Kiev" came from old Slavic via Russian to English, and "Prague"
# came from old Slavic via French to English, so the two cases have something
# in common.)  Admittedly English-language spelling of Ukrainian names is
# controversial, and some day "Kyiv" may become substantially more popular in
# English; in the meantime, stick with the traditional English "Kiev" as that
# means less disruption for our users.

# Zone	NAME		STDOFF	RULES	FORMAT	[UNTIL]
# This represents most of Ukraine.  See above for the spelling of "Kiev".
Zone Europe/Kiev	2:02:04 -	LMT	1880
			2:02:04	-	KMT	1924 May  2 # Kiev Mean Time
			2:00	-	EET	1930 Jun 21
			3:00	-	MSK	1941 Sep 20
			1:00	C-Eur	CE%sT	1943 Nov  6
			3:00	Russia	MSK/MSD	1990 Jul  1  2:00
			2:00	1:00	EEST	1991 Sep 29  3:00
			2:00	E-Eur	EE%sT	1995
			2:00	EU	EE%sT

@K-S-A
Copy link

K-S-A commented Apr 28, 2024

Hi @rafaelfranca, can we consider reopening this PR?

Both of the above sources have been updated in the last couple of years.

https://github.com/tzinfo/tzinfo-data/blame/master/lib/tzinfo/data/definitions/Europe/Kiev.rb is an alias for https://github.com/tzinfo/tzinfo-data/blame/master/lib/tzinfo/data/definitions/Europe/Kyiv.rb since this commit tzinfo/tzinfo-data@5a58dcb.

The content of https://www.iana.org/time-zones is also changed in eggert/tz@e13e9c5. The actual info as for now is https://github.com/eggert/tz/blob/main/europe#L3831-L3840:

# Zone	NAME		STDOFF	RULES	FORMAT	[UNTIL]
Zone Europe/Kyiv	2:02:04 -	LMT	1880
			2:02:04	-	KMT	1924 May  2 # Kyiv Mean Time
			2:00	-	EET	1930 Jun 21
			3:00	-	MSK	1941 Sep 20
			1:00	C-Eur	CE%sT	1943 Nov  6
			3:00	Russia	MSK/MSD	1990 Jul  1  2:00
			2:00	1:00	EEST	1991 Sep 29  3:00
			2:00	C-Eur	EE%sT	1996 May 13
			2:00	EU	EE%sT

@rafaelfranca
Copy link
Member

YES!

Can you open a new PR? I can't reopen this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants