Use major + minor AR versions in 'Directly inheriting' error message

[radar]

The error message when inheriting directly from ActiveRecord::Migration had two things wrong with it:

1. It mentioned the Rails release, instead of the Active Record release.
2. The version number was hard-coded to 4.2.

Let's use the current version of active record for this error.

[rafaelfranca]

I think we need to keep 4.2 here. That was the only version that didn't have the version subclasses and migrations that still are using direct inheritance were probably created in 4.2.

But I'm not sure, new migrations being written right now would also see the same exception and in that case #{major}.#{minor} makes sense.

It would be good to have a way to differentiate, but I don't think we have and there is more harm in using 6.1 migration to code that was written in 4.2 than using 4.2 for code just being written.

What do you think?

[radar]

I think if someone was hand writing a migration now they’ll leave off the version number and the suggestion should be to use the version of AR that they’re using, not an older version.

…

On 16 Jan 2021, 08:17 +1100, Rafael França ***@***.***>, wrote: @rafaelfranca commented on this pull request. In activerecord/lib/active_record/migration.rb: > "\n" \ - " class #{subclass} < ActiveRecord::Migration[4.2]" + " class #{subclass} < ActiveRecord::Migration[#{major}.#{minor}]" I think we need to keep 4.2 here. That was the only version that didn't have the version subclasses and migrations that still are using direct inheritance were probably created in 4.2. But I'm not sure, new migrations being written right now would also see the same exception and in that case #{major}.#{minor} makes sense. It would be good to have a way to differentiate, but I don't think we have and there is more harm in using 6.1 migration to code that was written in 4.2 than using 4.2 for code just being written. What do you think? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[rafaelfranca]

True, this will be on Rails 7.0, so all the old migrations that should be using 4.2 are already using it.

I'll merge and update the test monday.