Support NullsFirst for all databases. #42245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kbrock thanks for your PR - looks good 👍🏻 Can you please squash your commits down into a single commit and I'll merge it. |
|
thanks @pixeltrix all set Before, it didn't allow me to |
|
Sorry, I missed this - shouldn't these tests in |
Most databases order tables with the `NULL` value first, having it before
all other data values. Postgres has `NULLS` last.
Fortunately, ANSI SQL has an option to allow the database to specify where NULLS
come out in this sort order
ORDER BY column ASC NULLS FIRST
MS SQL, SQLite, Oracle, and Postgres all follow this syntax. Unfortunately, MySql
does not.
Before:
PostgreSQL: both `.nulls_first()` and `.nulls_last()` work as designed.
Others: both raise a runtime error.
After:
MySQL: `.nulls_first()` works as designed.
MySQL: `.nulls_last()` raises a runtime error
Others: both work as designed
|
thank you @pixeltrix I was concerned running it on the main branch with an override in mysql would complain. looks like it is working, though all those time and date failures distract me from finding anything that I caused |
|
@kbrock thanks for the prompt update! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most databases order tables with the
NULLvalue first, having it beforeall other data values. Postgres has
NULLSlast.Fortunately, ANSI SQL has an option to allow the database to specify where NULLS
come out in this sort order
MS SQL, SQLite, Oracle, and PostgreSQL all follow this syntax. Unfortunately, MySQL does not.
Before:
PostgreSQL: both
.nulls_first()and.nulls_last()work as designed.Others: both raise a runtime error.
After:
PostgreSQL: both work as designed.
MySQL:
.nulls_first()works as designed.MySQL:
.nulls_last()raises a runtime errorOthers: both work as designed
#38131 introduced this to Postgres, this PR adds the great feature to the rest of the databases.