Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing punctuations in activerecord CHANGELOG [ci-skip] #43536

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions activerecord/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,10 @@

The behavior now is:

`columns`: (unchanged) raises a db error if the table does not exist
`columns_hash`: (unchanged) raises a db error if the table does not exist
`primary_keys`: (unchanged) returns `nil` if the table does not exist
`indexes`: (changed for mysql2) returns `[]` if the table does not exist
`columns`: (unchanged) raises a db error if the table does not exist.
`columns_hash`: (unchanged) raises a db error if the table does not exist.
`primary_keys`: (unchanged) returns `nil` if the table does not exist.
`indexes`: (changed for mysql2) returns `[]` if the table does not exist.

*Eileen M. Uchitelle*

Expand Down Expand Up @@ -418,7 +418,7 @@
* Add option to disable schema dump per-database.

Dumping the schema is on by default for all databases in an application. To turn it off for a
specific database use the `schema_dump` option:
specific database, use the `schema_dump` option:

```yaml
# config/database.yml
Expand Down Expand Up @@ -617,7 +617,7 @@

* Fix compatibility with `psych >= 4`.

Starting in Psych 4.0.0 `YAML.load` behaves like `YAML.safe_load`. To preserve compatibility
Starting in Psych 4.0.0 `YAML.load` behaves like `YAML.safe_load`. To preserve compatibility,
Active Record's schema cache loader and `YAMLColumn` now uses `YAML.unsafe_load` if available.

*Jean Boussier*
Expand Down Expand Up @@ -1147,8 +1147,8 @@

*Eileen M. Uchitelle*, *John Crepezzi*

* Support hash config for `structure_dump_flags` and `structure_load_flags` flags
Now that Active Record supports multiple databases configuration
* Support hash config for `structure_dump_flags` and `structure_load_flags` flags.
Now that Active Record supports multiple databases configuration,
we need a way to pass specific flags for dump/load databases since
the options are not the same for different adapters.
We can use in the original way:
Expand Down