Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better proc/lambda route representation in bin/rails routes #43787

Merged
merged 1 commit into from Dec 7, 2021

Conversation

skyksandr
Copy link
Contributor

Summary

Change proc defined route representation from:

<Proc:RandomObjectId "/full/path/to/config/routes">

To:

"Inline handler (Proc/Lambda)"

We are using result of bin/rails routes inspection in CI automations. We recently added proc defined /health endpoint and found out that the result of bin/rails routes now changes on every run.
Looking deeper I confirmed that this is a result of .inspect call and added a condition for Procs

Other Information

Feedback is greatly appreciated.

Before:
<Proc:RandomObjectId "/full/path/to/config/routes">
After:
"Inline handler (Proc/Lambda)"
@rails-bot rails-bot bot added the actionpack label Dec 7, 2021
@skyksandr skyksandr changed the title Better proc/lambda route representation in bin/rails routes Better proc/lambda route representation in bin/rails routes Dec 7, 2021
@rafaelfranca rafaelfranca merged commit ac90d5a into rails:main Dec 7, 2021
@skyksandr skyksandr deleted the better-proc-route-inspection branch December 7, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants