Don't start the server for the failure screenshot #43836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `before_setup` fails, for example with fixture errors, the failure is stored, `setup` is skipped, and `take_failed_screenshot` is called. Taking a screenshot triggers starting the server which will probably fail since fixtures are not properly loaded. This generates another failure and makes it harder to debug the fixture failure. If the server was not already started, it makes no sense to take a screenshot since it is not relevant. This commit skips taking a failure screenshot if no browser session has been started.
rafaelfranca
added a commit
that referenced
this pull request
Dec 15, 2021
Don't start the server for the failure screenshot
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
before_setupfails, for example with fixture errors, the failure is stored,setupis skipped, andtake_failed_screenshotis called. Taking a screenshot triggers starting the server which will probably fail since fixtures are not properly loaded. This generates another failure and makes it harder to debug the fixture failure.If the server was not already started, it makes no sense to take a screenshot since it is not relevant.
This commit skips taking a failure screenshot if no browser session has been started.
Other Information
Tested with Rails 6.1.4.1.