Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start the server for the failure screenshot #43836

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Don't start the server for the failure screenshot #43836

merged 1 commit into from
Dec 15, 2021

Commits on Dec 11, 2021

  1. Don't start the server for the failure screenshot

    When `before_setup` fails, for example with fixture errors, the failure is stored, `setup` is skipped, and `take_failed_screenshot` is called.  Taking a screenshot triggers starting the server which will probably fail since fixtures are not properly loaded.  This generates another failure and makes it harder to debug the fixture failure.
    
    If the server was not already started, it makes no sense to take a screenshot since it is not relevant.
    
    This commit skips taking a failure screenshot if no browser session has been started.
    donv committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    1dfcffb View commit details
    Browse the repository at this point in the history