fix ordered migrations for single db in multi db environment #43988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshugoyal-git
force-pushed
the
fix-migrations-order
branch
from
f2ea547
to
422ce5c
Compare
eileencodes
added a commit
that referenced
this pull request
Jan 5, 2022
fix ordered migrations for single db in multi db environment
|
Thanks for the PR @himanshu-goyal-vineti! Backported to 7-0-stable in a0c0938. Fixes #44077 in addition to #43833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The migrations were not correctly ordered when we have intermediate migrations pending in multi-db environment and we did a
rails db:migrateThis resulted in the last active migration being reverted.
Here is the issue: #43833
This change helps possibly fixing it.