Remove body content from redirect responses #44554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern browsers don't render this HTML so it goes unused in practice.
The delivered bytes are therefore a small waste (although very small)
and unnecessary and could be optimized away.
Additionally, the HTML fails validation. Using the W3C v.Nu, we see the
following errors:
Warning: Consider adding a lang attribute to the html start tag to declare the language of this document.
Error: Start tag seen without seeing a doctype first. Expected <!DOCTYPE html>.
Error: Element head is missing a required instance of child element title.
These errors may surface in site-wide compliance tests (either internal
tests or external contractual tests). Avoid the false positives by
removing the HTML.
While these warnings and errors could be resolved, it would be simpler
on future maintenance to remove the body altogether (especially as it
isn't rendered by the browser). As the same string is copied around a
few places, this removes multiple touch points to resolve the current
validation errors as well as new ones.
Many other frameworks and web servers don't include an HTML body on
redirect, so there isn't a reason for Rails to do so. By removing the
custom Rails HTML, there are fewing "fingerprints" that a malicious bot
could use to identify the backend technologies.
Application controllers that wish to add a response body after calling
redirect_to can continue to do so.
This was referenced Mar 7, 2022
|
Hey @jdufresne .
Maybe I'm missing something, but how can I set the response body after this change? |
|
Does the following work for you: self.response_body = ... |
|
Thanks @jdufresne |
carlosantoniodasilva
added a commit
to heartcombo/devise
that referenced
this pull request
Apr 22, 2022
Rails is no longer returning a message with the response body on redirects, just an empty body. rails/rails#44554
carlosantoniodasilva
added a commit
to heartcombo/devise
that referenced
this pull request
Apr 22, 2022
Rails is no longer returning a message with the response body on redirects, just an empty body. rails/rails#44554
varyonic
added a commit
to varyonic/activeadmin-rails
that referenced
this pull request
Oct 31, 2023
varyonic
added a commit
to varyonic/activeadmin-rails
that referenced
this pull request
Nov 8, 2023
* rails-7.1: Rails 7.1 no longer populates redirect body (rails/rails#44554). Calling silence on ActiveSupport::Deprecation is deprecated and will be removed from Rails (use Rails.application.deprecators.silence instead) Deprecator setting has been deprecated. run db:drop, db:create and db:migrate in a separate commands (probably due to rails/rails#49349) Override and revert rails/rails#46699 for now, move test database from /storage back to /db Rails 7.1 replaces config.cache_classes with config.enable_reloading in template environment/test.rb Add Rails 7.1 test gem file. to_default_s is deprecated and will be removed from Rails 7.2 (use to_s instead) ActionView::OutputBuffer refactored by rails/rails#45614 (Rails 7.1) See rails/rails#36020
aaron-contreras
added a commit
to opf/openproject
that referenced
this pull request
Jan 10, 2024
aaron-contreras
added a commit
to opf/openproject
that referenced
this pull request
Jan 10, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 11, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 11, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 12, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 12, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 12, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 12, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 15, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 15, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 16, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 16, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 23, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 23, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 27, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 27, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 29, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 29, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 30, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 30, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 30, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Jan 30, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Feb 1, 2024
dombesz
pushed a commit
to opf/openproject
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern browsers don't render this HTML so it goes unused in practice.
The delivered bytes are therefore a small waste (although very small)
and unnecessary and could be optimized away.
Additionally, the HTML fails validation. Using the W3C v.Nu, we see the
following errors:
These errors may surface in site-wide compliance tests (either internal
tests or external contractual tests). Avoid the false positives by
removing the HTML.
While these warnings and errors could be resolved, it would be simpler
on future maintenance to remove the body altogether (especially as it
isn't rendered by the browser). As the same string is copied around a
few places, this removes multiple touch points to resolve the current
validation errors as well as new ones.
Many other frameworks and web servers don't include an HTML body on
redirect, so there isn't a reason for Rails to do so. By removing the
custom Rails HTML, there are fewing "fingerprints" that a malicious bot
could use to identify the backend technologies.
Application controllers that wish to add a response body after calling
redirect_to can continue to do so.