Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer set sql_auto_is_null #45134

Merged
merged 1 commit into from May 19, 2022

Conversation

HParker
Copy link
Contributor

@HParker HParker commented May 19, 2022

Since version 5.5 the default has been off. Now we can stops setting the variable manually and leaves it up to the user to set that variable if needed.

Reopening from #44739

closes: #44667

cc: @casperisfine

@xiankaing
Copy link

Associated issue: #44667

@byroot
Copy link
Member

byroot commented May 19, 2022

Let’s add a changelog entry, and then it’s good for me

@HParker HParker force-pushed the stop-explicitly-setting-sql_auto_is_null branch from 82b9bf6 to dd83feb Compare May 19, 2022 17:55
Since version 5.5 the default has been off, we no longer have to manually turn it off.
@HParker HParker force-pushed the stop-explicitly-setting-sql_auto_is_null branch from dd83feb to a79c1a6 Compare May 19, 2022 17:57
@HParker
Copy link
Contributor Author

HParker commented May 19, 2022

Updated thanks @byroot ❤️

@byroot byroot merged commit 0100a27 into rails:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stop explicitly setting sql_auto_is_null to zero
3 participants