Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no longer set sql_auto_is_null #45134

Merged
merged 1 commit into from
May 19, 2022
Merged

no longer set sql_auto_is_null #45134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion activerecord/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
* Stop setting `sql_auto_is_null`

Since version 5.5 the default has been off, we no longer have to manually turn it off.

*Adam Hess*

* Fix `touch` to raise an error for readonly columns.

*fatkodima*
Expand Down Expand Up @@ -35,7 +41,7 @@

* Support encrypted attributes on columns with default db values.

This adds support for encrypted attributes defined on columns with default values.
This adds support for encrypted attributes defined on columns with default values.
It will encrypt those values at creation time. Before, it would raise an
error unless `config.active_record.encryption.support_unencrypted_data` was true.

Expand Down
3 changes: 0 additions & 3 deletions activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,9 +787,6 @@ def supports_rename_column?
def configure_connection
variables = @config.fetch(:variables, {}).stringify_keys

# By default, MySQL 'where id is null' selects the last inserted id; Turn this off.
variables["sql_auto_is_null"] = 0

# Increase timeout so the server doesn't disconnect us.
wait_timeout = self.class.type_cast_config_to_integer(@config[:wait_timeout])
wait_timeout = 2147483 unless wait_timeout.is_a?(Integer)
Expand Down