Action cable command callbacks testing #45445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
force-pushed
the
feat/connection-callbacks-testing
branch
from
da04e85
to
fea8a5e
Compare
palkan
force-pushed
the
feat/connection-callbacks-testing
branch
from
fea8a5e
to
cc393b0
Compare
palkan
force-pushed
the
feat/connection-callbacks-testing
branch
from
cc393b0
to
5c9ce80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the follow-up for #44696.
I found that testing callbacks is currently not supported due to some limitations of our test stubs.
Other Information
I don't really like the way Action Cable testing currently uses connection stubs, but this is the limitation of the current library design (connections are highly coupled with event loops and servers). Back in a while, I tried to tackle this: #27648. Maybe, we should re-visit this problem in the future (for Rails 8, maybe?).