Fix #46244 Remove innerHTML usage to avoid self-XSS #46269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR looks good. The red tests seem unrelated, but you could rebase to |
codergeek121
force-pushed
the
fix-xss-on-route-error-page
branch
from
9612fd5
to
be177e4
Compare
|
Thank you for the review. I rebased and everything is passing now :) |
byroot
added a commit
that referenced
this pull request
Nov 1, 2022
Fix #46244 Remove innerHTML usage to avoid self-XSS
byroot
added a commit
that referenced
this pull request
Nov 1, 2022
Fix #46244 Remove innerHTML usage to avoid self-XSS
byroot
added a commit
that referenced
this pull request
Nov 1, 2022
Fix #46244 Remove innerHTML usage to avoid self-XSS
|
@byroot This fix did not make it into any change log, nor any release notes (that I can find), and Synk is still reporting it as an unfixed, current vulnerability in 7.0.4.2, with no possible upgrade path to any fixed version. It also says that a fix has been merged to
Of course the fix has been released. How can we avoid this situation in the future? I have reported the error in Synk's vulnerability database to Synk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because of #46244 . Fixes #46244
Detail
I replaced innerHTML usages with
innerText. Problematic input is now displayed and not evaluated.To test it, use the suggested #46244 (comment) input. There should be no alert box and the displayed
<tr>s are not broken but display the input.