Never connect to the database in define_attribute_methods initializer #48793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup: rails#48743 After careful consideration, unless users have a schema cache dump loaded and `check_schema_cache_dump_version = false`, we have no choice but to arbitrate between resiliency and performance. If we define attribute methods during boot, we allow them to be shared between forked workers, and prevent the first requests to be slower. However, by doing so we'd trigger a connection to the datase, which if it's unresponsive could lead to workers not being able to restart triggering a cascading failure. Previously Rails used to be in some sort of middle-ground where it would define attribute methods during boot if for some reason it was already connected to the database at this point. But this is now deemed undesirable, as an application initializer inadvertantly establishing the database connection woudl lead to a readically different behavior.
casperisfine
force-pushed
the
define-attributes-initializer
branch
from
777ef86
to
de765e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #48743
After careful consideration, unless users have a schema cache dump loaded and
check_schema_cache_dump_version = false, we have no choice but to arbitrate between resiliency and performance.If we define attribute methods during boot, we allow them to be shared between forked workers, and prevent the first requests to be slower.
However, by doing so we'd trigger a connection to the datase, which if it's unresponsive could lead to workers not being able to restart triggering a cascading failure.
Previously Rails used to be in some sort of middle-ground where it would define attribute methods during boot if for some reason it was already connected to the database at this point.
But this is now deemed undesirable, as an application initializer inadvertantly establishing the database connection woudl lead to a readically different behavior.
FYI: @zarqman @matthewd