Commits on Jul 24, 2023

1. Never connect to the database in define_attribute_methods initializer …

   Followup: rails#48743
   
   After careful consideration, unless users have a schema cache dump loaded
   and `check_schema_cache_dump_version = false`, we have no choice but
   to arbitrate between resiliency and performance.
   
   If we define attribute methods during boot, we allow them to be shared
   between forked workers, and prevent the first requests to be slower.
   
   However, by doing so we'd trigger a connection to the datase, which
   if it's unresponsive could lead to workers not being able to restart
   triggering a cascading failure.
   
   Previously Rails used to be in some sort of middle-ground where
   it would define attribute methods during boot if for some reason
   it was already connected to the database at this point.
   
   But this is now deemed undesirable, as an application initializer
   inadvertantly establishing the database connection woudl lead to
   a readically different behavior.

   

   byroot committed Jul 24, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for de765e3
   • Browse repository at this point

   Copy the full SHA

   de765e3 View commit details

   Browse the repository at this point in the history