When running in CI, do not fail if Rails frameworks with tables have not been fully installed #49509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not been activated Fixes rails#49500 The Rails first run experience should not require installing Action Text/Active Storage/Action Mailbox so you can run tests in CI. You should only install these features if you actually use them. It also should not require changing the require of `rails/all`. With this PR we keep the first run experience we had before `7.1.0` but you can still customise all these things if you want.
ghiculescu
force-pushed
the
eager-load-missing-frameworks
branch
from
8eda2a3
to
dc8910c
Compare
ghiculescu
changed the title
huacnlee
added a commit
to ruby-china/homeland
that referenced
this pull request
Oct 6, 2023
|
You are now coupling railtie to all those frameworks and causing Rails to not be able to remove Action Text, Active Storage or Action Mailbox from apps. This isn't a solution for that problem. Automatically running the install commands would be a better solution. |
tomhughes
added a commit
to tomhughes/openstreetmap-website
that referenced
this pull request
Oct 7, 2023
tomhughes
added a commit
to tomhughes/openstreetmap-website
that referenced
this pull request
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49500
The Rails first run experience should not require installing Action Text/Active Storage/Action Mailbox so you can run tests in CI. You should only install these features if you actually use them. It also should not require changing the require of
rails/all.This config works in production when eager loaded, so we should support it in test too.
With this PR we keep the first run experience we had before
7.1.0but you can still customise all these things if you want.