Take AR affixes into account for Action Text database models

[chaadow]

Follow up to #50247 and #50167 cc @jonathanhefner

This removes the redundant hard coded table names to make the models compatible with ActiveRecord::Base.{prefix|suffix}

This also adds prefix/suffix in the dummy app to force the entire test suite to be agnostic to hard-coded table names.

[eileencodes]

Same request here, can you add tests for the prefix/suffix? Thanks!

[chaadow]

Thanks for the review @eileencodes I've added the missing tests.

As a side note, I've added tests in the previous PR for all isolated engines, that's why I thought I can skip them here.

rails/railties/test/railties/engine_test.rb

Lines 1293 to 1317 in 900dc32

	test "take ActiveRecord table_name_prefix into consideration when defining table_name_prefix" do
	@plugin.write "lib/bukkits.rb", <<-RUBY
	module Bukkits
	class Engine < ::Rails::Engine
	isolate_namespace(Bukkits)
	end
	end
	RUBY
	@plugin.write "app/models/bukkits/post.rb", <<-RUBY
	module Bukkits
	class Post < ActiveRecord::Base
	end
	end
	RUBY
	add_to_config <<-RUBY
	config.active_record.table_name_prefix = "ar_prefix_"
	RUBY
	boot_rails
	assert_equal "ar_prefix_bukkits_posts", Bukkits::Post.table_name
	assert_equal "ar_prefix_bukkits_", Bukkits.table_name_prefix
	end

[eileencodes]

Thanks for adding a test, I left some comments about simplifying it.

[eileencodes]

This should be in a teardown instead of the ensure.

[eileencodes]

Needing to delete the prefix and suffix seems kind of overkill for this test. I'd rather just test a model or two and hardcode the test name. Testing every model isn't necessary.

[eileencodes]

This isn't a record_test it's a table_name_test. Can you update the test name and filename?

[jonathanhefner]

As a side note, I've added tests in the previous PR for all isolated engines, that's why I thought I can skip them here.

That was part of the reason why I didn't feel a test was necessary for #50167. The other part is that we are removing configuration in favor of convention. If we were going the other way (adding hard-coded table names to prevent them from incorporating ActiveRecord::Base.table_name_{prefix,suffix}), then I would have definitely included a test. But since we're reverting to the default behavior, it didn't seem necessary, the same way we don't test that the derived table name is snake_cased and plural (outside of activerecord/test tests).

Of course, more test coverage doesn't hurt. 😃

[chaadow]

Thanks for the review @eileencodes I've applied the changes here and in #50300

[eileencodes]

Thank you!