Take AR affixes into account for Action Mailbox database models #50300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaadow
force-pushed
the
fix_actionmailbox_table_prefix
branch
from
d9490f1
to
6dde461
Compare
eileencodes
requested changes
Dec 8, 2023
chaadow
force-pushed
the
fix_actionmailbox_table_prefix
branch
4 times, most recently
from
174c72a
to
07fea21
Compare
chaadow
force-pushed
the
fix_actionmailbox_table_prefix
branch
from
07fea21
to
1b97f97
Compare
eileencodes
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #50247 and #50167 cc @jonathanhefner
This removes the redundant hard coded table names to make the models compatible with
ActiveRecord::Base.{prefix|suffix}This also adds prefix/suffix in the dummy app to force the entire test suite to be agnostic to hard-coded table names.