New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry ActionableError
s when running tests
#50941
Conversation
482fd19
to
6fb4adb
Compare
085ef36
to
b481c34
Compare
Looks like we have some railties tests continuously timing out. We'll look into that ASAP. |
ActionError
s when running testsActionableError
s when running tests
b481c34
to
59a5422
Compare
Needed to turn off the flag in the generated app in a few more tests 👍 |
@andrewn617 Let's go ahead and rebase + add the new framework default, so new apps can onboard to this behaviour. |
fddb9cd
to
7694426
Compare
501627b
to
c86c1d5
Compare
12ac53a
to
3898474
Compare
Ultimately @gmcgibbon and I decided against a framework configuration for this. The other use case we are working on is for "Did you mean" errors when the command name is typoed. In that case, the app is not even loaded yet, so the configuration is not available to be checked. So instead, we are going with |
3898474
to
55db842
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @andrewn617 can you please update the description of the PR and git commit message so this is accurate to the new approach. I'll merge after that.
If running in an interactive console, the user will be given the option to correct the error and re-run the tests. Co-authored-by: Gannon McGibbon <gannon.mcgibbon@gmail.com>
55db842
to
bc9c665
Compare
@gmcgibbon Done. |
Thanks! ❤️ |
Motivation / Background
This Pull Request has been created because I want to make it easier to retry actionable errors that occur when running tests. Rails already knows how to recover these errors, so lets make it possible for the user to recover from them and run their tests without exiting the process.
Detail
Allow Actionable Errors encountered when running tests to be retried.
This feature is only available in an interactive terminal.
Additional information
Right now this is only implemented in the Test Runner, but I'd also like to follow up with a similar implementation for
Rails::Command::CorrectableNameError
s.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]