Fix Active Storage test configurations for CI #50967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
reviewed
Feb 5, 2024
casperisfine
reviewed
Feb 5, 2024
zzak
force-pushed
the
asto/fix-controller-tests
branch
5 times, most recently
from
79b21b8
to
1623e28
Compare
This change is an up-port of rails#50787 which applied a similar fix to 7-1-stable. Since these tests weren't running before, we didn't notice when the DirectUploads controller tests were broken. My theory is that it has something to do with changing `response.parsed_body` to return a HWIA (in rails#49003). This change is different from the 7-1-stable PR in that it removes the need to stringify or symbolize any keys, since we are comparing the metadata with string keys. This is a follow up to rails#43705. Co-authored-by: Sean Doyle <seanpdoyle@users.noreply.github.com> Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
zzak
force-pushed
the
asto/fix-controller-tests
branch
from
1623e28
to
4873347
Compare
zzak
added a commit
to zzak/rails
that referenced
this pull request
Feb 7, 2024
Apply rails#50967 to 7-1-stable, to simplify the tests for metadata and corrects the test configuration path with improvements to the readability. This change improves upon rails#50787 in that it removes the need to stringify or symbolize any keys, since we are comparing the metadata with string keys. This is a follow up to rails#43705. Co-authored-by: Sean Doyle <seanpdoyle@users.noreply.github.com> Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is an up-port of #50787 which applied a similar fix to 7-1-stable.
Since these tests weren't running before, we didn't notice when the DirectUploads controller tests were broken. My theory is that it has something to do with changing
response.parsed_bodyto return a HWIA (in #49003).This change is different from the 7-1-stable PR in that it removes the need to stringify or symbolize any keys, since we are comparing the metadata with string keys. This is a follow up to #43705.
This PR came out of the work in #50427, but since I was able to reproduce these failures on main, I wanted to fix them first.