Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ConnectionPool#connection #51230

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Commits on Mar 1, 2024

  1. Deprecate ConnectionPool#connection

    Replaced by `#lease_connection` to better reflect what it does.
    
    `ActiveRecord::Base#connection` is deprecated in the same way
    but without a removal timeline nor a deprecation warning.
    
    Inside the Active Record test suite, we do remove `Base.connection`
    to ensure it's not used internally.
    
    Some callsites have been converted to use `with_connection`,
    some other have been more simply migrated to `lease_connection`
    and will serve as a list of callsites to convert for
    rails#50793
    byroot committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7263da5 View commit details
    Browse the repository at this point in the history