Deprecate ConnectionPool#connection
#51230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
deprecate-connection
branch
2 times, most recently
from
a439e64
to
9f6fa2b
Compare
Replaced by `#lease_connection` to better reflect what it does. `ActiveRecord::Base#connection` is deprecated in the same way but without a removal timeline nor a deprecation warning. Inside the Active Record test suite, we do remove `Base.connection` to ensure it's not used internally. Some callsites have been converted to use `with_connection`, some other have been more simply migrated to `lease_connection` and will serve as a list of callsites to convert for rails#50793
casperisfine
force-pushed
the
deprecate-connection
branch
from
9f6fa2b
to
7263da5
Compare
Earlopain
reviewed
Mar 1, 2024
| alias_method :connection, :lease_connection # TODO: deprecate | ||
| def connection | ||
| ActiveRecord.deprecator.warn(<<~MSG) | ||
| ConnectionPoool#connection is deprecated and will be removed |
There was a problem hiding this comment.
Oh, I wasn't even meaning this. I just noticed that Poool doesn't look very correct. My bad, should have been more specific.
There was a problem hiding this comment.
Yes, I meant to fix that too, but I must be tired 😫
aidanharan
added a commit
to rails-sqlserver/activerecord-sqlserver-adapter
that referenced
this pull request
Mar 11, 2024
aidanharan
added a commit
to rails-sqlserver/activerecord-sqlserver-adapter
that referenced
this pull request
Mar 14, 2024
tagliala
added a commit
to ifad/chronomodel
that referenced
this pull request
Mar 29, 2024
Ref: - rails/rails@7263da5 - rails/rails#51230 Close #275
tagliala
added a commit
to ifad/chronomodel
that referenced
this pull request
Mar 29, 2024
Ref: - rails/rails@7263da5 - rails/rails#51230 Close #275
tagliala
added a commit
to ifad/chronomodel
that referenced
this pull request
Mar 29, 2024
Ref: - rails/rails@7263da5 - rails/rails#51230 Close #275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced by
#lease_connectionto better reflect what it does.ActiveRecord::Base.connectionis deprecated in the same way but without a removal timeline nor a deprecation warning.Inside the Active Record test suite, we do remove
Base.connectionto ensure it's not used internally.Some callsites have been converted to use
with_connection, some other have been more simply migrated tolease_connectionand will serve as a list of callsites to convert for #50793FYI: @matthewd