Allow primary_key: association option to be composite
#51345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Association's `primary_key` can be composite when derived from associated class `primary_key` or `query_constraints`. But we don't allow setting it explicitly even though Rails is already capable of supporting it. This commit allows `primary_key` association option to be an array.
rafaelfranca
added a commit
that referenced
this pull request
Mar 18, 2024
…to-be-an-array Allow `primary_key:` association option to be composite
|
Do such changes need CHANGELOG or considered internal? I see this fixes user facing behaviour? |
Oh, they absolutely do as they are public. Thanks for reminding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #50850
A bit related to: #49671 (comment)
Association's
primary_keycan be composite when derived from associated classprimary_keyorquery_constraints. But we don't allow setting it explicitly even though Rails is already capable of supporting it.This commit allows
primary_keyassociation option to be an array.Here is an example where we already assume that
primary_keycan be an Array:rails/activerecord/lib/active_record/reflection.rb
Line 540 in cc4f368