Remove proxy_association references from guides [ci-skip]
#51449
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 6795a24 made `proxy_assocation` non-public API by marking it `:nodoc`. This change remove references to `proxy_association` from the guides.
akhilgkrishnan
approved these changes
Mar 31, 2024
vipulnsward
approved these changes
Apr 3, 2024
|
Thanks @akhilgkrishnan and @vipulnsward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6795a24 made
proxy_assocationnon-public API by marking it:nodoc.This change remove references to
proxy_associationfrom the guides.Similar to
proxy_association, do we also need to maketargetnon-public?https://edgeapi.rubyonrails.org/classes/ActiveRecord/Associations/CollectionProxy.html#method-i-target
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]