Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PostgreSQL] Remove NULLS FIRST/LAST. Closes #5152 #5168

Merged
merged 1 commit into from
Feb 27, 2012
Merged

[PostgreSQL] Remove NULLS FIRST/LAST. Closes #5152 #5168

merged 1 commit into from
Feb 27, 2012

Conversation

kennyj
Copy link
Contributor

@kennyj kennyj commented Feb 25, 2012

When we use the postgresql adapter and construct distinct select clause, we have a problem with NULLS first/last.

without fix
=> posts.updater_idnulls first AS alias_0
with fix
=> posts.updater_id AS alias_0

closes #5152

This original issue was reported for 3-2-stable.

@kennyj kennyj mentioned this pull request Feb 25, 2012
Closed
tenderlove added a commit that referenced this pull request Feb 27, 2012
@tenderlove
Merge pull request #5168 from kennyj/fix_5152
699e460 
[PostgreSQL] Remove NULLS FIRST/LAST. Closes #5152
@tenderlove tenderlove merged commit 699e460 into rails:master Feb 27, 2012
@kennyj kennyj mentioned this pull request Aug 1, 2012
Closed
kennyj added a commit to kennyj/rails that referenced this pull request Aug 2, 2012
@kennyj
Backport rails#5168 to 3-2-stable. Fix a problem that NULLS is ignore…
f137c2b 
…d by postgresql_adapter.rb while creating distincts.
carlosantoniodasilva added a commit that referenced this pull request Aug 2, 2012
@carlosantoniodasilva
Merge pull request #7232 from kennyj/fix_7200
59c4b22 
Fix #7200. Backport #5168 to 3-2-stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

postgresql_adapter+def distinct+nulls
2 participants
@kennyj @tenderlove