Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backtrace to development routing error page #6131

Merged
merged 1 commit into from May 3, 2012

Conversation

schneems
Copy link
Member

@schneems schneems commented May 2, 2012

If a user gets a routing error due to a view helper such as using user_path without an :id they must go to their logs to see the backtrace. By adding in the trace template, a user can see which line the error occurred on without leaving the browser.

When a routing error occurs outside of the view the application trace will be blank and will not confuse developers.

Before PR: http://cl.ly/3x332b0V2d0E0Q1G0C1t
After PR: http://cl.ly/2O431D0A1u2Q2p130A3t

If a user gets a routing error due to a view helper such as using user_path without an :id they must go to their logs to see the backtrace. By adding in the trace template, a user can see which line the error occurred on without leaving the browser.

When a routing error occurs outside of the view the application trace will be blank and will not confuse developers.
@qrush
Copy link
Contributor

qrush commented May 2, 2012

Nice!! 👍 💣

@mcmire
Copy link
Contributor

mcmire commented May 3, 2012

Oh yeah, this is great.

spastorino added a commit that referenced this pull request May 3, 2012
Add backtrace to development routing error page
@spastorino spastorino merged commit b93def9 into rails:master May 3, 2012
@kuraga
Copy link

kuraga commented Nov 1, 2012

GREAT!!!!!! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants