AR::Relation#model would be a better API than AR::Relation#klass #6606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be nice :-) |
|
Agree. I would change the internals to use |
|
+1, i also propose in my PR #4367 to rename |
rafaelfranca
added a commit
that referenced
this pull request
Aug 21, 2012
AR::Relation#model would be a better API than AR::Relation#klass
sayap
added a commit
to sayap/will_paginate
that referenced
this pull request
Oct 31, 2013
`collection.first.class` will spawn a LIMIT 1 query, while `collection.empty?` will spawn a COUNT query. The latter is not a problem since a COUNT query is needed anyway, so redundant ones will retrieve from cache. The former, however, can add unnecessary load to the database. As far as I can tell, ActiveRecord::Relation has a `klass` attribute since the beginning in 0e0866e0565bd530ee265b9298accff4185f7022, so it should work fine. Since rails/rails#6606, the attribute is also aliased as `model`, though this change is only available in Rails 4.x.
sayap
added a commit
to sayap/will_paginate
that referenced
this pull request
Oct 31, 2013
`collection.first.class` will spawn a LIMIT 1 query, while `collection.empty?` will spawn a COUNT query. The latter is not a problem since a COUNT query is needed anyway, so redundant ones will retrieve from cache. The former, however, can add unnecessary load to the database. As far as I can tell, ActiveRecord::Relation has a `klass` attribute since the beginning, so it should be fine. The attribute is also aliased as `model` since rails/rails#6606, though this change is only available in Rails 4.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modelfeels more natural for programmers, and this would make library authors a bit happier since it's compatible withDM::Collectionhttps://github.com/datamapper/dm-core/blob/9d9f739/lib/dm-core/collection.rb#L45